Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vev: Log where MGT received its signal from #4139

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cartoush
Copy link
Contributor

This PR makes MGT log from which PID originates the signal it received.
It does that by adding the SIGINFO flag to sigaction in order to use sa_sigaction insead of sa_handler and grab the struct siginfo_t which contains the origin PID

Copy link
Member

@nigoroll nigoroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense, i have nitpicks

bin/varnishd/mgt/mgt_vcl.c Outdated Show resolved Hide resolved
lib/libvarnish/vev.c Outdated Show resolved Hide resolved
In order to keep a pointer to the siginfo_t in struct vevsig in
struct vev we need to define an opaque typedef to siginfo_t* since we do
not want to include <signal.h> in vev.h
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants