Budgets Resource and Data Source #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whereandy
commented
Apr 16, 2024
| cost_report_token = vantage_cost_report.demo_report.token | ||
| periods = [ | ||
| { | ||
| start_at = "2023-12-01" |
There was a problem hiding this comment.
The format for the dates is YYYY-MM-DD, not ISO-8601.
whereandy
commented
Apr 16, 2024
| return dst | ||
| } | ||
|
|
||
| func applyBudgetPayload(ctx context.Context, isDataSource bool, src *modelsv2.Budget, dst *budgetModel) diag.Diagnostics { |
There was a problem hiding this comment.
@conner n.b., unlike what you did, the model is not the receiver of this function, because i'm using the autogenerated model, (budgetModel is a resource_budget.BudgetModel) and can't attach methods to it.
whereandy
commented
Apr 16, 2024
| // both the data source and the resource | ||
| type budgetModel resource_budget.BudgetModel | ||
| type budgetPerformanceModel resource_budget.PerformanceValue | ||
| type budgetPeriodResourceModel struct { |
There was a problem hiding this comment.
i hate that we need separate ways to describe the period depending on whether it is for a data source or a resource, but cant find a better workaround for this.
conner
approved these changes
Apr 16, 2024
vantage/budget_resource_model.go
Outdated
| } | ||
|
|
||
| if src.Periods != nil { | ||
| // var l types.List |
needs tests. bump vantage-go examples tf fmt cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.