Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stopping permission requests on activity restore #76

Merged
merged 1 commit into from
Apr 21, 2021

Conversation

rprunskas
Copy link
Contributor

Fixes crash:
#51

@codecov
Copy link

codecov bot commented Dec 11, 2020

Codecov Report

Merging #76 (7a830b3) into master (1551c05) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #76   +/-   ##
=======================================
  Coverage   61.87%   61.87%           
=======================================
  Files           6        6           
  Lines         139      139           
  Branches       20       20           
=======================================
  Hits           86       86           
  Misses         47       47           
  Partials        6        6           
Impacted Files Coverage Δ
.../com/vanniktech/rxpermission/RealRxPermission.java 75.00% <0.00%> (-2.42%) ⬇️
...va/com/vanniktech/rxpermission/ShadowActivity.java 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1551c05...7a830b3. Read the comment docs.

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reproduce the crash? If so, what do you do?

@rprunskas
Copy link
Contributor Author

Can you reproduce the crash? If so, what do you do?

Yes, I can.

  1. Request for permissions, but don't grant/deny permission, just leave that system dialog.
  2. Close app and kill it.
  3. Restore app and grant or deny previously requested permission.

@prashermanas
Copy link

@vanniktech This fixes the issue any reason why its being not merged yet ?

@vanniktech
Copy link
Owner

Close app and kill it

@rprunskas how do you do that?

@rprunskas
Copy link
Contributor Author

I use stop button - "Kill the Application — easiest way is to just click the red “stop” button in Android Studio."

Please check this article:
https://medium.com/inloopx/android-process-kill-and-the-big-implications-for-your-app-1ecbed4921cb

@vanniktech
Copy link
Owner

@rprunskas so this button?

Screenshot 2021-04-20 at 09 31 22

@rprunskas
Copy link
Contributor Author

yes

Copy link
Owner

@vanniktech vanniktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@vanniktech vanniktech merged commit 7477311 into vanniktech:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants