Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export supported locales for isAlpha, isMobilePhone, etc #890

Merged

Conversation

profnandaa
Copy link
Member

This commit exports supported locales for the following functions:

  • isAlpha -> isAlphaLocales
  • isAlphanumeric -> isAlphanumericLocales
  • isMobilePhone -> isMobilePhoneLocales

fixes #815

@profnandaa
Copy link
Member Author

Fixing the m/c

@chriso
Copy link
Collaborator

chriso commented Sep 2, 2018

Good stuff, thanks 😄 Do you mind rebasing to fix the conflict?

This commit exports supported locales for the following functions:
- isAlpha -> isAlphaLocales
- isAlphanumeric -> isAlphanumericLocales
- isMobilePhone -> isMobilePhoneLocales

fixes validatorjs#815
@andela-anandaa andela-anandaa force-pushed the feat-815-export-supported-locates branch from 49efcf3 to cd67bad Compare September 2, 2018 12:10
@profnandaa
Copy link
Member Author

@chriso - sure, done a rebase 👍

@chriso chriso merged commit 35453c5 into validatorjs:master Sep 2, 2018
@profnandaa profnandaa deleted the feat-815-export-supported-locates branch September 2, 2018 12:12
andela-anandaa pushed a commit to profnandaa/validator.js that referenced this pull request Sep 2, 2018
This commit exports the list of supported locales for `isFloat`
as `isFloatLocales`

Ref: validatorjs#815, validatorjs#891, follow up for validatorjs#890
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export the list of supported countries for isPostalCode, locales for isMobilePhone, etc...
2 participants