Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isMagnetURI #877 #884

Merged
merged 5 commits into from
Aug 21, 2018
Merged

Conversation

Adibla
Copy link
Contributor

@Adibla Adibla commented Aug 21, 2018

Add simple function/test to validate magnet URI string

@chriso
Copy link
Collaborator

chriso commented Aug 21, 2018

Thanks for the PR 😄

Do you mind adding an entry to the README?

@chriso
Copy link
Collaborator

chriso commented Aug 21, 2018

Can you fix the lint errors?

/home/travis/build/chriso/validator.js/src/lib/isMagnetURI.js
  1:1  error  Expected 1 empty line after import statement not followed by another import  import/newline-after-import
  5:1  error  Expected indentation of 2 spaces but found 4                                 indent
  6:1  error  Expected indentation of 2 spaces but found 4                                 indent
/home/travis/build/chriso/validator.js/test/validators.js
  5631:1  error  More than 2 blank lines not allowed  no-multiple-empty-lines
  5632:1  error  Trailing spaces not allowed          no-trailing-spaces

@chriso
Copy link
Collaborator

chriso commented Aug 21, 2018

Thanks!

@chriso chriso merged commit 65e16f8 into validatorjs:master Aug 21, 2018
@chriso chriso mentioned this pull request Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants