Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): Add regex for Somalia so-SO #2175

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

ohersi
Copy link
Contributor

@ohersi ohersi commented Feb 2, 2023

Added regex validation for Somalia (so-SO) mobile phone numbers, country codes referenced from these documents:

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, we're just about to make our next release and the preps are done. Unfortunately this will miss the train but should be on the next one.

Please fix the merge conflicts.

@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. ✅ LGTM 🎉 first-pr labels Feb 2, 2023
ezkemboi
ezkemboi previously approved these changes Feb 6, 2023
Copy link
Member

@ezkemboi ezkemboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please check @rubiin @profnandaa @tux-tn

test/validators.test.js Outdated Show resolved Hide resolved
test/validators.test.js Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f89e0a8) compared to base (54d330c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2175   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       105           
  Lines         2324      2324           
  Branches       586       586           
=========================================
  Hits          2324      2324           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ezkemboi ezkemboi added the ready-to-land For PRs that are reviewed and ready to be landed label Feb 7, 2023
@profnandaa profnandaa merged commit ecce35f into validatorjs:master Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr ✅ LGTM mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants