validation for Pakistan's passport #2073
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #2073 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 104 104
Lines 2308 2308
Branches 578 578
=========================================
Hits 2308 2308
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
rubiin
previously approved these changes
Oct 17, 2022
rubiin
added
the
mc-to-land
|
@digambar-t7 fix the merge conflict and we are ready to go |
tux-tn
requested changes
Oct 18, 2022
There was a problem hiding this comment.
Thank you for your PR @digambar-t7 ,
Country codes need to follow ISO 3166-1 alpha-2. It means it should be PK and PH !
tux-tn
added
🧹 needs-update
|
Ok @tux-tn , will be back soon. |
tux-tn
approved these changes
Oct 18, 2022
There was a problem hiding this comment.
Thank you @digambar-t7 for the quick edits! LGTM 🎉
Is your contribution part of Hacktoberfest?
|
Yes @tux-tn , it is a part of my Hactoberfest contribution. |
tux-tn
added
ready-to-land
ParthJadhav
approved these changes
Oct 18, 2022
profnandaa
added
mc-to-land
|
Sorry missed this in my latest clean-ups, I should get this in #2164. |
WikiRik
reviewed
Feb 1, 2023
| @@ -154,7 +154,7 @@ Validator | Description | |||
| **isMultibyte(str)** | check if the string contains one or more multibyte chars. | |||
| **isNumeric(str [, options])** | check if the string contains only numbers.<br/><br/>`options` is an object which defaults to `{no_symbols: false}` it also has locale as an option. If `no_symbols` is true, the validator will reject numeric strings that feature a symbol (e.g. `+`, `-`, or `.`).<br/><br/>`locale` determine the decimal separator and is one of `['ar', 'ar-AE', 'ar-BH', 'ar-DZ', 'ar-EG', 'ar-IQ', 'ar-JO', 'ar-KW', 'ar-LB', 'ar-LY', 'ar-MA', 'ar-QA', 'ar-QM', 'ar-SA', 'ar-SD', 'ar-SY', 'ar-TN', 'ar-YE', 'bg-BG', 'cs-CZ', 'da-DK', 'de-DE', 'en-AU', 'en-GB', 'en-HK', 'en-IN', 'en-NZ', 'en-US', 'en-ZA', 'en-ZM', 'es-ES', 'fr-FR', 'fr-CA', 'hu-HU', 'it-IT', 'nb-NO', 'nl-NL', 'nn-NO', 'pl-PL', 'pt-BR', 'pt-PT', 'ru-RU', 'sl-SI', 'sr-RS', 'sr-RS@latin', 'sv-SE', 'tr-TR', 'uk-UA']`. | |||
| **isOctal(str)** | check if the string is a valid octal number. | |||
| **isPassportNumber(str, countryCode)** | check if the string is a valid passport number.<br/><br/>(countryCode is one of `[ 'AM', 'AR', 'AT', 'AU', 'BE', 'BG', 'BY', 'BR', 'CA', 'CH', 'CN', 'CY', 'CZ', 'DE', 'DK', 'DZ', 'EE', 'ES', 'FI', 'FR', 'GB', 'GR', 'HR', 'HU', 'IE' 'IN', 'IR', 'ID', 'IS', 'IT', 'JP', 'KR', 'LT', 'LU', 'LV', 'LY', 'MT', 'MX', 'MY', 'MZ', 'NL', 'PL', 'PT', 'RO', 'RU', 'SE', 'SL', 'SK', 'TH', 'TR', 'UA', 'US' ]`. | |||
There was a problem hiding this comment.
@profnandaa same here about the 'TH'
profnandaa
added a commit
that referenced
this pull request
Feb 2, 2023
* maintentance: clean up, closes #2073 --------- Co-authored-by: Digambar Tupurwadi <digz@kali> Co-authored-by: Digambar <digambartu@gmail.com>
|
merged in #2164 |
profnandaa
added a commit
that referenced
this pull request
Feb 2, 2023
* maintentance: clean up, closes #2073 --------- Co-authored-by: Digambar <digambartu@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2072
This adds the validation for Pakistani passport