Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isAlpha, isAlphanumeric): add ko-KR locale #1965

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

Dongkyuuuu
Copy link
Contributor

Hello! add new locale ko-KR

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (513c7bc) compared to base (d698f4f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1965   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          104       104           
  Lines         2308      2308           
  Branches       578       578           
=========================================
  Hits          2308      2308           
Impacted Files Coverage Δ
src/lib/alpha.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

HyungJu
HyungJu previously approved these changes May 17, 2022
@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 17, 2022
profnandaa
profnandaa previously approved these changes Oct 17, 2022
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, LGTM.
I'll see how I can fix all the README merge conflicts in one PR.

@Dongkyuuuu Dongkyuuuu dismissed stale reviews from profnandaa and HyungJu via e45cfaa October 17, 2022 05:14
@Dongkyuuuu
Copy link
Contributor Author

Dongkyuuuu commented Oct 17, 2022

Thanks for your contribution, LGTM. I'll see how I can fix all the README merge conflicts in one PR.

@profnandaa
I fix it!
plz check again.

@profnandaa profnandaa merged commit 7b47f53 into validatorjs:master Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants