Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add Kiribati en-KI locale #1820

Closed

Conversation

c-tanner
Copy link
Contributor

Adds validation for Kiribati mobile numbers.

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #1820 (acdf4b0) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1820   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...acdf4b0. Read the comment docs.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pls fix the merge conflict and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa profnandaa changed the title feat(isMobilePhone): Add Kiribati validation feat(isMobilePhone): add Kiribati en-KI locale Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] squashed from #1820

Clean up validator and add trailing comma
@profnandaa
Copy link
Member

No worries, your commit is now added here #1851, thanks!

@profnandaa profnandaa closed this Oct 31, 2021
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] squashed from #1820

Clean up validator and add trailing comma
profnandaa pushed a commit that referenced this pull request Oct 31, 2021
[chore] squashed from #1820

Clean up validator and add trailing comma
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants