feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

tarob0ba · 2021-10-10T23:43:28Z

I have added a regex for validating Cameroonian mobile numbers which should work. I'm not super comfortable with regular expressions, so if I have screwed something up, please let me know and I will (hopefully) be able to fix it.

Checklist

PR contains only changes related; no stray files, etc.
README updated (where applicable)
Tests written (where applicable)

I have added a regex for validating Cameroonian mobile numbers which should work. I'm not super comfortable with regular expressions, so if I have screwed something up, please let me know. I have done some basic testing and it has functioned fine thus far.

tarob0ba · 2021-10-10T23:45:05Z

Fixing the commas now. My bad!

Fix my sloppy tests. I'm really tired and probably should not be working on this, but I accidentally added an extra digit while typing.

codecov · 2021-10-10T23:52:44Z

Codecov Report

Merging #1772 (374724a) into master (5773869) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #1772   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2052      2052           
  Branches       463       463           
=========================================
  Hits          2052      2052

Impacted Files	Coverage Δ
src/lib/isMobilePhone.js	`100.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5773869...374724a. Read the comment docs.

tarob0ba · 2021-10-10T23:53:14Z

I apologize for the mistakes that I've made while doing this; I'm really anxious that I've messed something critical up.

tux-tn · 2021-10-18T07:43:14Z

I apologize for the mistakes that I've made while doing this; I'm really anxious that I've messed something critical up.

No worries, tests and linter are here to fix those mistakes. I suggest next time you run them locally to detect that kind of problems, you just need to run npm test before committing and pushing your code

tux-tn

Thank you for your PR @beckettnormington !

I Added a comment concerning your regex, can you address it?

tux-tn · 2021-10-18T07:53:35Z

src/lib/isMobilePhone.js

@@ -74,6 +74,7 @@ const phones = {
  'fi-FI': /^(\+?358|0)\s?(4(0|1|2|4|5|6)?|50)\s?(\d\s?){4,8}\d$/,
  'fj-FJ': /^(\+?679)?\s?\d{3}\s?\d{4}$/,
  'fo-FO': /^(\+?298)?\s?\d{2}\s?\d{2}\s?\d{2}$/,
+  'fr-CM': /^((237) ?|(\+237) ?)([0-9] ?){9}$/,


Looks like you want to validate country prefix with and without the + sign. An easier way to do this would be:

/^(\+?237)? ([0-9] ?){9}$/

I have two questions tho:

Are spaces valid in Cameroon mobile phones (Most of the mobile phone validators we have don't allow spaces)

There is some carrier prefixes for mobile phone numbers as shown here. Can you please update your regex to take into consideration that mobile prefix?

Thanks for the feedback! I'm currently writing a regex that takes your comments into account.

1.) Spaces don't seem to be valid, my bad.
2.) I'm taking the latest updated mobile prefix (6) from November 21, 2014. If that needs to be updated, let me know as I wasn't completely sure.

I'll update the tests to invalidate landline numbers.

Alright, done. 😄

Thank you @beckettnormington, looks like you still have a space between the country prefix and the local part of the phone number. Can you correct that and we should be good to go

Whoops, completely forgot about that! I’ll fix that now. My bad!

Add mobile prefix (6) to regex, remove space allowance, and optimize regex

Sorry!

tux-tn

LGTM ! Thank you 🎉

profnandaa · 2021-10-30T06:18:01Z

@beckettnormington -- pls fix the merge conflict on README and we should be good to go.

tarob0ba · 2021-10-30T21:28:52Z

Resolved merge conflict, @profnandaa.

tux-tn

LGTM. Thank you for fixing merge conflicts

* Add Cameroon validation regex I have added a regex for validating Cameroonian mobile numbers which should work. I'm not super comfortable with regular expressions, so if I have screwed something up, please let me know. I have done some basic testing and it has functioned fine thus far. * Update README to include fr-CM in isMobilePhone * Add (very) basic testing for Cameroonian mobile number * Fix missing brace (whoops!) * Fix commas (I hope) * Fix sloppy tests Fix my sloppy tests. I'm really tired and probably should not be working on this, but I accidentally added an extra digit while typing. * Update regex for correctness Add mobile prefix (6) to regex, remove space allowance, and optimize regex * Update tests for correctness * Remove invalid space Sorry! * Rerun failed tests (internal server error)

tarob0ba added 4 commits October 10, 2021 19:20

Add Cameroon validation regex

1c89471

I have added a regex for validating Cameroonian mobile numbers which should work. I'm not super comfortable with regular expressions, so if I have screwed something up, please let me know. I have done some basic testing and it has functioned fine thus far.

Update README to include fr-CM in isMobilePhone

1152440

Add (very) basic testing for Cameroonian mobile number

822b212

Fix missing brace (whoops!)

44ae45a

tarob0ba added 2 commits October 10, 2021 19:48

Fix commas (I hope)

e7d32ae

Fix sloppy tests

b01fa08

Fix my sloppy tests. I'm really tired and probably should not be working on this, but I accidentally added an extra digit while typing.

tarob0ba changed the title ~~feat(isMobilePhone): Add mobile phone validation for Cameroon (fr-CM)~~ feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) Oct 11, 2021

tarob0ba mentioned this pull request Oct 11, 2021

Mobile Phone validations - For The First Time Contributors #1761

Open

rootkit7628 mentioned this pull request Oct 12, 2021

Add madagascar mobile phone validation #1774

Open

tux-tn requested changes Oct 18, 2021

View reviewed changes

tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 18, 2021

tarob0ba added 2 commits October 18, 2021 16:27

Update regex for correctness

86720d8

Add mobile prefix (6) to regex, remove space allowance, and optimize regex

Update tests for correctness

c62fe96

tarob0ba requested a review from tux-tn October 18, 2021 20:30

tarob0ba added 2 commits October 19, 2021 16:50

Remove invalid space

a0c6226

Sorry!

Rerun failed tests (internal server error)

9926f9e

tux-tn previously approved these changes Oct 20, 2021

View reviewed changes

tux-tn added hacktoberfest-accepted ready-to-land For PRs that are reviewed and ready to be landed and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 20, 2021

profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021

Merge branch 'master' into patch-1

374724a

tarob0ba dismissed tux-tn’s stale review via 374724a October 30, 2021 21:27

tarob0ba requested a review from tux-tn October 30, 2021 21:29

tux-tn approved these changes Oct 30, 2021

View reviewed changes

profnandaa merged commit f2381e0 into validatorjs:master Oct 31, 2021

profnandaa mentioned this pull request Oct 31, 2021

release staging: November 2021 release (13.7.0) #1853

Closed

tarob0ba deleted the patch-1 branch November 1, 2021 00:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

tarob0ba commented Oct 10, 2021 •

edited

Loading

tarob0ba commented Oct 10, 2021 •

edited

Loading

codecov bot commented Oct 10, 2021 •

edited

Loading

tarob0ba commented Oct 10, 2021

tux-tn commented Oct 18, 2021 •

edited

Loading

tux-tn left a comment

tux-tn Oct 18, 2021

tarob0ba Oct 18, 2021 •

edited

Loading

tarob0ba Oct 18, 2021

tux-tn Oct 19, 2021

tarob0ba Oct 19, 2021

tarob0ba Oct 19, 2021

tux-tn left a comment

profnandaa commented Oct 30, 2021

tarob0ba commented Oct 30, 2021 •

edited

Loading

tux-tn left a comment

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

feat: (isMobilePhone) Add mobile phone validation for Cameroon (fr-CM) #1772

Conversation

tarob0ba commented Oct 10, 2021 • edited Loading

Checklist

tarob0ba commented Oct 10, 2021 • edited Loading

codecov bot commented Oct 10, 2021 • edited Loading

Codecov Report

tarob0ba commented Oct 10, 2021

tux-tn commented Oct 18, 2021 • edited Loading

tux-tn left a comment

Choose a reason for hiding this comment

tux-tn Oct 18, 2021

Choose a reason for hiding this comment

tarob0ba Oct 18, 2021 • edited Loading

Choose a reason for hiding this comment

tarob0ba Oct 18, 2021

Choose a reason for hiding this comment

tux-tn Oct 19, 2021

Choose a reason for hiding this comment

tarob0ba Oct 19, 2021

Choose a reason for hiding this comment

tarob0ba Oct 19, 2021

Choose a reason for hiding this comment

tux-tn left a comment

Choose a reason for hiding this comment

profnandaa commented Oct 30, 2021

tarob0ba commented Oct 30, 2021 • edited Loading

tux-tn left a comment

Choose a reason for hiding this comment

tarob0ba commented Oct 10, 2021 •

edited

Loading

tarob0ba commented Oct 10, 2021 •

edited

Loading

codecov bot commented Oct 10, 2021 •

edited

Loading

tux-tn commented Oct 18, 2021 •

edited

Loading

tarob0ba Oct 18, 2021 •

edited

Loading

tarob0ba commented Oct 30, 2021 •

edited

Loading