Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isMobilePhone): add Palestine ar-PS locale #1767

Closed
wants to merge 5 commits into from

Conversation

brendan-c
Copy link
Contributor

@brendan-c brendan-c commented Oct 9, 2021

feat(isMobilePhone) add Palestine validation (ar-PS)

  • Added validation for Palestine mobile phone numbers
  • Wrote test for Palestine mobile phone number validation
  • Updated readme to include ar-PS

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #1767 (f434556) into master (13651ea) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1767   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2029      2029           
  Branches       457       457           
=========================================
  Hits          2029      2029           
Impacted Files Coverage Δ
src/lib/isMobilePhone.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 13651ea...f434556. Read the comment docs.

Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @brendan-c and thank you for your PR! Can you please address my comment below?

@@ -14,6 +14,7 @@ const phones = {
'ar-LY': /^((\+?218)|0)?(9[1-6]\d{7}|[1-8]\d{7,9})$/,
'ar-MA': /^(?:(?:\+|00)212|0)[5-7]\d{8}$/,
'ar-OM': /^((\+|00)968)?(9[1-9])\d{6}$/,
'ar-PS': /^(\+?970|0)5[8|9](\d{7})$/,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't prefixes for mobile phone numbers 9 and 6 instead of 8? The only source i can find is this wikipedia article

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could be correct. The information this was based on was from http://www.wtng.info/wtng-970-ps.html but it lists it's source as Paltel, which appears to no longer be a mobile carrier

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made the changes requested to validator.js 079c113

And updated the tests f434556

@tux-tn tux-tn added 🎉 first-pr 🧹 needs-update For PRs that need to be updated before landing labels Oct 14, 2021
Copy link
Member

@tux-tn tux-tn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thank you for your efforts 🎉

@tux-tn tux-tn added ready-to-land For PRs that are reviewed and ready to be landed hacktoberfest-accepted and removed 🧹 needs-update For PRs that need to be updated before landing labels Oct 18, 2021
@profnandaa
Copy link
Member

@brendan-c - please fix the merge conflict and we should be good to go.

@profnandaa profnandaa added the mc-to-land Just merge-conflict standing between the PR and landing. label Oct 30, 2021
@profnandaa
Copy link
Member

Your work is now merged here #1851

@profnandaa profnandaa closed this Oct 31, 2021
@profnandaa profnandaa changed the title feat: (isMobilePhone) add Palestine validation feat(isMobilePhone): add Palestine ar-PS locale Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 first-pr hacktoberfest-accepted mc-to-land Just merge-conflict standing between the PR and landing. ready-to-land For PRs that are reviewed and ready to be landed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants