Fix Space Error in isSlug() #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please have a look and tell me if there is anything that was left out while fixing it. |
profnandaa
approved these changes
May 31, 2020
|
LGTM, thanks for your contribution and welcome to the project 🎉 |
|
Thanks, looking forward to contributing more in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1287
feat(isSlug): Fixed the problem in which isSlug() was also returning
truefor slugs with spaces for e.g.not a-slug.I created a regex which will reject the slug while testing if it has spaces in the beginning, in the middle or at the end and has replaced my regex with the current one.