Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added isTaxId #1336

Merged
merged 2 commits into from
Jun 3, 2020
Merged

feat: added isTaxId #1336

merged 2 commits into from
Jun 3, 2020

Conversation

rubiin
Copy link
Member

@rubiin rubiin commented May 30, 2020 •
edited
Loading

added a validator to check taxid
addresses #1320

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@rubiin
Copy link
Member Author

rubiin commented May 30, 2020

@profnandaa

profnandaa
profnandaa requested changes May 31, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one thing, please rewrite a little to support locales/contry-codes starting with US as default.

@rubiin
Copy link
Member Author

rubiin commented Jun 1, 2020

@profnandaa taxid is only valid for US as per wikipedia

@profnandaa
Copy link
Member

I think other locations have equivalents, perhaps going by a different name... will be better to allow future expansion to other locales.

@rubiin
Copy link
Member Author

rubiin commented Jun 1, 2020

sure

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Jun 2, 2020
@rubiin
Copy link
Member Author

rubiin commented Jun 2, 2020

@profnandaa i have added locales

@rubiin rubiin requested a review from profnandaa June 2, 2020 15:20
profnandaa
profnandaa approved these changes Jun 3, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@profnandaa profnandaa merged commit 8adc4c6 into validatorjs:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubiin @profnandaa