Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1329 adding locale option for the isNumeric validator #1330

Merged
merged 1 commit into from
May 30, 2020

Conversation

matthieu88160
Copy link
Contributor

Adding a new localeoption to the isNumeric validator, in order to allow by language decimal separator validation.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Will need extra pair of eyes @tux-tn @ezkemboi @rubiin

@profnandaa
Copy link
Member

@matthieu88160 -- thanks for your contrib and welcome to the project!

Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@profnandaa profnandaa merged commit 2514fbb into validatorjs:master May 30, 2020
gustavohenke added a commit to express-validator/express-validator that referenced this pull request Jun 21, 2020
TigerStar429 pushed a commit to TigerStar429/expressjs-validator that referenced this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants