Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1327 : Adding option to allow primitives without BC break #1328

Merged
merged 3 commits into from
May 29, 2020

Conversation

matthieu88160
Copy link
Contributor

Allow use of primitives ("null", "true", "false") with a new isJson option "allow_primitives". Making this option false by default to avoid BC breaks.

@profnandaa
Copy link
Member

Thanks for your PR! Could you remove the unrelated changes from the PR, even if they are being auto-generated.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label May 29, 2020
@matthieu88160
Copy link
Contributor Author

Auto-generated files removed from the diff.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the contrib! 🎉

@profnandaa profnandaa merged commit dbb54f5 into validatorjs:master May 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants