Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supported IBAN for Iran #1293

Merged
merged 1 commit into from
May 26, 2020
Merged

Supported IBAN for Iran #1293

merged 1 commit into from
May 26, 2020

Conversation

meness
Copy link
Contributor

@meness meness commented May 5, 2020

Fixes #1291

profnandaa
profnandaa reviewed May 25, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you update the README and we should be good to go.

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label May 25, 2020
@meness
Copy link
Contributor Author

meness commented May 25, 2020

@profnandaa I don't see this necessary as you haven't said anything about supported IBANs on README yet. Let me know if you want me to include as it helps devs to know what is supported by isIBAN()

@profnandaa
Copy link
Member

@meness -- my bad, had confused this for some other validator; will land.

@profnandaa profnandaa merged commit aa31434 into validatorjs:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa left review comments

Assignees
No one assigned
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support IBAN for Iran
2 participants
@meness @profnandaa