Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Semantic Versioning Specification (SemVer) Validator #1246

Merged
merged 5 commits into from
Feb 11, 2020
Merged

feat: Add Semantic Versioning Specification (SemVer) Validator #1246

merged 5 commits into from
Feb 11, 2020

Conversation

hamzahejja
Copy link
Contributor

  • Add isSemVer(str) validator to check for Semantic Versioning Specification (SemVer)
  • Added tests to cover valid/invalid SemVer strings.
  • Reference: Semantic Versioning 2.0.0

@hamzahejja
Copy link
Contributor Author

@profnandaa @tux-tn Could you have a look at this and review it when possible? Thanks!

profnandaa
profnandaa reviewed Feb 11, 2020
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contrib! 🎉 Looks good with me, just one small comment below, you can make the change then we land.

src/lib/isSemVer.js Outdated Show resolved Hide resolved
@profnandaa profnandaa merged commit a87165a into validatorjs:master Feb 11, 2020
@AubreyHewes AubreyHewes mentioned this pull request Feb 11, 2020
Closed
@hamzahejja hamzahejja deleted the add-isSemanticVersioning-validator branch April 24, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hamzahejja @profnandaa