Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsDate String Validation #1170

Closed
wants to merge 4 commits into from
Closed

IsDate String Validation #1170

wants to merge 4 commits into from

Conversation

MeghaMehrotra
Copy link

No description provided.

@MeghaMehrotra MeghaMehrotra mentioned this pull request Oct 21, 2019
Closed
profnandaa
profnandaa requested changes Oct 21, 2019
View reviewed changes
Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated changes from the PR, and also add tests for isDate.

@melroy89
Copy link

I do see a testcase. Nice work @MeghaMehrotra

@MeghaMehrotra
Copy link
Author

I do see a testcase. Nice work @MeghaMehrotra
Thanks :) @Danger89

@profnandaa
Copy link
Member

Closing for #1270

@profnandaa profnandaa closed this Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@profnandaa profnandaa profnandaa requested changes

@melroy89 melroy89 melroy89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MeghaMehrotra @melroy89 @profnandaa