Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added isOctal validator including tests and updated README. #1153

Merged
merged 1 commit into from
Oct 13, 2019

Conversation

ayala-io
Copy link
Contributor

Added a validator isOctal(str) to validate strings intended to be octal numbers. It is intended for general octal numbers. It also accepts the common prefix of '0c' although it is not required to have the prefix to validate.

Changes:

  • README.md has been updated to reflect the new isOctal addition
  • src/lib/isOctal.js source of the validator function
  • src/index.js modified to include isOctal
  • test/validators.js added test cases to test isOctal

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your contribution! 🎉

@profnandaa profnandaa merged commit 4162ae7 into validatorjs:master Oct 13, 2019
@ayala-io ayala-io deleted the add-isOctal-validator branch October 13, 2019 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants