Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added BR Postal Code #1014

Closed
wants to merge 2 commits into from
Closed

Added BR Postal Code #1014

wants to merge 2 commits into from

Conversation

bloodf
Copy link

@bloodf bloodf commented Apr 11, 2019

Added BR Postal Code to isPostalCode function.

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can just stick to the portal code changes (regex + tests), you can leave out the linting/formatting changes you made.

@@ -57,7 +58,7 @@ const patterns = {

export const locales = Object.keys(patterns);

export default function (str, locale) {
export default function(str, locale) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis failing because of this, you need to unstage this particular change; we're using standardJS formatting guidelines.

@@ -4,7 +4,9 @@ import fs from 'fs';
import vm from 'vm';
import validator from '../index';

let validator_js = fs.readFileSync(require.resolve('../validator.js')).toString();
let validator_js = fs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, just unstage these changes

@profnandaa profnandaa added the 🧹 needs-update For PRs that need to be updated before landing label Apr 15, 2019
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 11, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
ezkemboi added a commit to ezkemboi/validator.js that referenced this pull request Aug 12, 2019
- fix issues relating to BR postal code
- add more tests
- closes validatorjs#1014
@profnandaa
Copy link
Member

Closed in #1049

@profnandaa profnandaa closed this Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 needs-update For PRs that need to be updated before landing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants