fix: filter vCenter local file privileges properly, skip KUBECONFIG check when updating passwords in direct mode #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
dosubot
bot
added
size:M
ahmad-ibra
previously approved these changes
Sep 4, 2024
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #207 +/- ##
==========================================
- Coverage 53.38% 53.33% -0.06%
==========================================
Files 45 45
Lines 6247 6253 +6
==========================================
Hits 3335 3335
- Misses 2069 2073 +4
- Partials 843 845 +2
Continue to review full report in Codecov by Sentry.
|
ahmad-ibra
approved these changes
Sep 4, 2024
TylerGillson
added a commit
that referenced
this pull request
Sep 4, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.4](v0.1.3...v0.1.4) (2024-09-04) ### Bug Fixes * filter vCenter local file privileges properly, skip KUBECONFIG check when updating passwords in direct mode ([#207](#207)) ([29f1db4](29f1db4)) ### Dependency Updates * **deps:** update module github.com/validator-labs/validator-plugin-oci to v0.3.3 ([#209](#209)) ([e553967](e553967)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
N/A
Description
KUBECONFIGcheck when updating passwords in direct mode