feat: support configuring oci validationType on a rule #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:M
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #161 +/- ##
==========================================
- Coverage 38.92% 38.87% -0.05%
==========================================
Files 41 41
Lines 5429 5435 +6
==========================================
Hits 2113 2113
- Misses 2929 2935 +6
Partials 387 387
Continue to review full report in Codecov by Sentry.
|
TylerGillson
approved these changes
Aug 13, 2024
arturshadnik
added a commit
that referenced
this pull request
Aug 13, 2024
fix: typo in plugin name test: decrease scope of maas client mock chore: change tab to spaces to satisfy lint style: remove extra blank line test: move mocks into maas service chore: add nosec directive feat: support configuring oci validationType on a rule (#161) This PR swaps out configuring the `SkipLayerValidation` flag (which no longer exists) for the `ValidationType` which can be set to none, fast, or full. For now, i've opted to only allow the tui to configure this field on the host level (ie for all artifacts on in a rule). We can also add extra prompts to override for a particular artifact, but i felt like it would just make the tui flow more cumbersome. feat: WIP - add maas plugin feat: WIP: add maas plugin chore: make reviewable
ahmad-ibra
pushed a commit
that referenced
this pull request
Aug 19, 2024
🤖 I have created a release *beep* *boop* --- ## [0.1.2](v0.1.1...v0.1.2) (2024-08-19) ### Features * add maas plugin ([#160](#160)) ([ab9f21a](ab9f21a)) * allow selecting aws creds from filesystem ([#171](#171)) ([c3a714c](c3a714c)) * allow specifying Azure cloud to connect to ([#170](#170)) ([6a4a704](6a4a704)) * read vCenter privileges from local file or editor ([#152](#152)) ([94ddd90](94ddd90)) * set exit code 2 on validation failure; restore debug log file ([#150](#150)) ([2a3fe4d](2a3fe4d)) * support configuring oci validationType on a rule ([#161](#161)) ([8dfc501](8dfc501)) * support direct oci validation of private registries ([#173](#173)) ([9cfeab9](9cfeab9)) ### Bug Fixes * correct TUI flow for `validator install -o --apply` ([#169](#169)) ([0912f6e](0912f6e)) * export creds for aws and azure direct check ([#167](#167)) ([5d569de](5d569de)) ### Dependency Updates * **deps:** update anchore/sbom-action action to v0.17.1 ([#163](#163)) ([416d23c](416d23c)) * **deps:** update github.com/validator-labs/validator-plugin-azure digest to b4687e5 ([#149](#149)) ([e7ab9a6](e7ab9a6)) * **deps:** update github.com/validator-labs/validator-plugin-vsphere digest to a93cb70 ([#147](#147)) ([79304b9](79304b9)) * **deps:** update module github.com/vmware/govmomi to v0.40.0 ([#162](#162)) ([acf4a25](acf4a25)) ### Refactoring * lazy configuration of oci auth and signature verification secrets ([#168](#168)) ([cc2c056](cc2c056)) * remove explicit TypeMetas; use vapi constants ([#154](#154)) ([28b321c](28b321c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR swaps out configuring the
SkipLayerValidationflag (which no longer exists) for theValidationTypewhich can be set to none, fast, or full.For now, i've opted to only allow the tui to configure this field on the host level (ie for all artifacts on in a rule). We can also add extra prompts to override for a particular artifact, but i felt like it would just make the tui flow more cumbersome.