-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support proxy configuration (env vars & CA certificate) #137
Conversation
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
==========================================
- Coverage 55.52% 55.17% -0.36%
==========================================
Files 9 9
Lines 850 850
==========================================
- Hits 472 469 -3
- Misses 353 354 +1
- Partials 25 27 +2 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
…cloud-labs/validator into feat-proxy-config
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just needs to have the chart/validator/README.md updated with make frigate
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
env
andproxy
) is now copied intovalues.yaml
for each plugin. This means that any plugin that requires proxy config must expect those values in that format.