Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support proxy configuration (env vars & CA certificate) #137

Merged
merged 14 commits into from
Nov 29, 2023

Conversation

TylerGillson
Copy link
Member

@TylerGillson TylerGillson commented Nov 28, 2023

  • Add proxy support for the validator manager container
  • Top-level proxy config (env and proxy) is now copied into values.yaml for each plugin. This means that any plugin that requires proxy config must expect those values in that format.
  • Add Dockerfile for building root CA initialization image

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #137 (2a105eb) into main (31746d6) will decrease coverage by 0.36%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
- Coverage   55.52%   55.17%   -0.36%     
==========================================
  Files           9        9              
  Lines         850      850              
==========================================
- Hits          472      469       -3     
- Misses        353      354       +1     
- Partials       25       27       +2     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31746d6...2a105eb. Read the comment docs.

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Copy link
Contributor

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs to have the chart/validator/README.md updated with make frigate

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
ahmad-ibra
ahmad-ibra previously approved these changes Nov 29, 2023
Copy link
Contributor

@ahmad-ibra ahmad-ibra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Tyler Gillson <tyler.gillson@gmail.com>
@TylerGillson TylerGillson merged commit 63c3bc8 into main Nov 29, 2023
6 of 7 checks passed
@TylerGillson TylerGillson deleted the feat-proxy-config branch November 29, 2023 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants