Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PBH CLI #3

Closed
wants to merge 80 commits into from
Closed

PBH CLI #3

wants to merge 80 commits into from

Conversation

vadymhlushko-mlnx
Copy link
Owner

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@vadymhlushko-mlnx
Fixed codestyle
559d210 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Removed YANG validation from 'config'
e20b2d0 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Generated from updated YANG model show CLI for PBH & fixed codestyle
0e44abe 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added generated config CLI for PBH
c5fe537 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed codestyle for config
77754cf 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added 'pbh' subcommand & removed 'hash-field-list' subcommand
2d0167f 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Removed leaf-lists CLI commands, added example of validation click op…
5a6ea76 
…tions

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added new data enums from YANG model
f94e0f0 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added show pbh ...
8dd0e7b 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added sceleton for PBH UT
3261502 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed show pbh table output
bb0a710 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added 'Symmetric' field to the 'show pbh hash-field' command
6a0c248 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed 'show pbh hash' output
0e20bc0 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed 'show pbh rule' output
466862d 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed codestyle for show CLI plugin
07000a6 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added 'show pbh statistics'
0305909 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added 'flow counter' column to 'show pbh rule'
68b07b2 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added sort, changed symmetric check, removed unused check
186ae9b 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added validation for --hash-field-list, --ip-mask
9f2b52f 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added is_exist_in_db()
b2b5472 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added is_match, interface_validator
4dca122 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed codestyle
e232188 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
HOT FIX
eff1729 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed issue with click callbacks
096602e 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed sort output for show CLI, typo fixes
be744a0 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added few 'hash-field' tests
3739757 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed issue with 'config pbh rule update'
4d005d8 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
HOTFIX for 'config pbh rule update' is_exist_in_db()
cf971b5 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added proper description for --ip-mask
e864d12 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added ip_mask & hash-field validation for ADD flow
3050212 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added exception handling for 'clear' subcommand
008eec3 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Unified click error msg format
56bb517 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed teardown for pbh_test.py
c0e423a 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed LGTM error
f51982e 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Rework of ip_mask_hash_field_correspondence()
fad30a7 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed functions name
6682add 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Codestyle
6bb079a 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
nazariig
nazariig reviewed Jul 13, 2021
View reviewed changes
config/plugins/pbh.py Outdated
if (ip_mask is None) and (hash_field in hf_v4_and_v6):
is_error = True

if (ip_mask is not None) and (hash_field in hf_no_ip):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymhlushko-mlnx if (ip_mask is not None) and (hash_field not in hf_v4_and_v6): ?

@vadymhlushko-mlnx
Added defines for config module
fd930ec 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
nazariig
nazariig reviewed Jul 13, 2021
View reviewed changes
config/plugins/pbh.py Outdated
hf_v4 = ['INNER_DST_IPV4', 'INNER_SRC_IPV4']
hf_v6 = ['INNER_DST_IPV6', 'INNER_SRC_IPV6']

if (ip_mask is None) and (hash_field in hf_v4_and_v6):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadymhlushko-mlnx what if hash_field is None? Do we guarantee that only ip_mask can be None inside this method?

vadymhlushko-mlnx and others added 16 commits July 13, 2021 15:17
@vadymhlushko-mlnx
Added cleanup of mocked db in UT
01c3cca 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Codestyle and other improvement
c22ce2a 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
improvements for show plugin
048774a 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fix for regexp & added --ether-type -> need to fix UT
88992c6 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed value for pbh regexp in UT
b2bad71 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed mock db & UT for show cli
c227a73 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Rework of inject_symmetric_field()
e7970a8 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added check for --flow-counter when displaing pbh statistics
7f208b2 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added new UT for pbh statistics
dd35eec 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added check for read pbh counters
438cea6 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Reworked sonic-clear cli group for pbh
ef680de 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Fixed help messages for config cli according to the new YANG model
9471b11 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@nazariig
[pbh]: Add CLI UM.
0d28690 
Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
@vadymhlushko-mlnx
Reworked clear after of mocked DB for UT, codestyle, changes some UT …
a4709f8 
…to parametrized

Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
@vadymhlushko-mlnx
Added PBH CLI user manual
a6fae69
@vadymhlushko-mlnx
Fixed description
6a19368 
Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
vadymhlushko-mlnx pushed a commit that referenced this pull request Nov 27, 2023
@JunhongMao @StormLiangMS
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
d9473c0 
…aidump_by_route_size (sonic-net#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  #1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  #2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  #3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  #5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
vadymhlushko-mlnx pushed a commit that referenced this pull request Jan 23, 2024
@JunhongMao
[VOQ][saidump] Modify generate_dump: replace save_saidump with save_s…
cd85569 
…aidump_by_route_size (sonic-net#2972)

* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561

Solution and modification:
To use the redis-db SAVE option to save the snapshot of DB each time and recover later, instead of looping through each entry in the table and saving it.

(1) Updated sonic-buildimage/build_debian.sh, to install Python library rdbtools into the host.
(2) Updated sonic-buildimage/src/sonic-sairedis/saidump/saidump.cpp, add a new option -r, which updates the rdbtools's output-JSON files' format.
(3) Add a new script file: files/scripts/saidump.sh, to do the below steps
  For each ASIC0, such as ASIC0,

  #1. Save the Redis data.
  sudo sonic-db-cli -n asic$1 SAVE > /dev/null

  #2. Move dump files to /var/run/redisX/
  docker exec database$1 sh -c "mv /var/lib/redis/dump.rdb /var/run/redis$1/"

  #3. Run rdb command to convert the dump files into JSON files
  sudo python /usr/local/bin/rdb --command json  /var/run/redis$1/dump.rdb | sudo tee /var/run/redis$1/dump.json > /dev/null

  #4. Run saidump -r to update the JSON files' format as same as the saidump before. Then we can get the saidump result in standard output.
  docker exec syncd$1 sh -c "saidump -r /var/run/redis$1/dump.json"

  #5. clear
  sudo rm -f /var/run/redis$1/dump.rdb
  sudo rm -f /var/run/redis$1/dump.json

(4) Update sonic-buildimage/src/sonic-utilities/scripts/generate_dump, replace saidump with saidump.sh
* * [saidump]
•	Saidump for DNX-SAI sonic-net/sonic-buildimage#13561
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nazariig nazariig nazariig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadymhlushko-mlnx @nazariig