[test_iface_namingmode] Adjusted the test according to the new buffer queue/pg counters optimization #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,7 @@ | |||
| from tests.common.utilities import wait, wait_until | |||
| from netaddr import IPAddress | |||
| from tests.common.helpers.assertions import pytest_assert | |||
| from tests.snmp.test_snmp_phy_entity import redis_get_keys | |||
There was a problem hiding this comment.
don't import from another test, copy redis_get_keys method to some common folder
| elif mode == 'default': | ||
| for intf in setup['default_interfaces']: | ||
| assert re.search(r'{}'.format(intf), show_queue_wm_mcast) is not None | ||
| if show_queue_wm_mcast != "Object map from COUNTERS_DB is empty, because counters are not configured in CONFIG_DB!": |
vadymhlushko-mlnx
changed the title
vadymhlushko-mlnx
changed the title
… queue/pg counters optimization Signed-off-by: Vadym Hlushko <vadymh@nvidia.com>
vadymhlushko-mlnx
force-pushed
the
master-test-iface-namingmode-fixes
branch
from
461472a
to
f512275
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
DEPENDS ON: INSERT PR
Summary: Adjusted the test
test_iface_namingmode.pyaccording to the new buffer queue/pg counters optimizationFixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Because of the new implementation sonic-swss/pull/2432 from now on, there is a valid case if there are no multicast counters inside the COUNTERS_DB.
In order for multicast counters to be presented in
COUNTERS_DBthe appropriate queues should be configured inside theCONFIG_DB(e.g"BUFFER_QUEUE|Ethernet14|7-8")How did you do it?
Change the testcases -
test_show_queue_counters,test_show_queue_persistent_watermark_multicast,test_show_queue_watermark_multicastHow did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation