Autonat protocol #739
Merged
Autonat protocol #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really cool to see this happening! Let me know in case there are any questions in regards to the specification. Also //CC @elenaf9 who implemented AutoNAT in rust-libp2p libp2p/rust-libp2p#2262 |
Menduist
reviewed
Jul 29, 2022
|
@lchenut I just pushed a commit which extracts the conn manager tracking from dialAndUpgrade, you should now be able to use dialAndUpgrade in canDial |
Menduist
reviewed
Jul 29, 2022
Menduist
reviewed
Jul 29, 2022
Menduist
reviewed
Jul 29, 2022
Menduist
reviewed
Jul 29, 2022
|
Ok, last detail before my approval, we should use a semaphore to limit the number of concurrent dial backs to avoid attacks 1 max seems like a sane default |
Menduist
reviewed
Aug 1, 2022
Menduist
reviewed
Aug 1, 2022
Menduist
reviewed
Aug 1, 2022
Menduist
previously approved these changes
Aug 1, 2022
elenaf9
reviewed
Aug 1, 2022
Menduist
previously approved these changes
Aug 3, 2022
Menduist
previously approved these changes
Aug 3, 2022
Menduist
approved these changes
Aug 23, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the AutoNAT Protocol