Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added trivial support for SVG via Html component #15539

Closed
wants to merge 1 commit into from
Closed

Added trivial support for SVG via Html component #15539

wants to merge 1 commit into from

Conversation

mstahv
Copy link
Member

@mstahv mstahv commented Dec 21, 2022

Description

Please list all relevant dependencies in this section and provide summary of the change, motivation and context.

Fixes # (issue)

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/guide/contributing/overview/
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Additional for Feature type of change

  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

@mstahv mstahv mentioned this pull request Dec 21, 2022
Open
@sonarcloud
Copy link

sonarcloud bot commented Dec 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Test Results

   931 files  ±0     931 suites  ±0   56m 10s ⏱️ -31s
5 834 tests ±0  5 798 ✔️ ±0  36 💤 ±0  0 ❌ ±0 
6 085 runs   - 2  6 042 ✔️  - 2  43 💤 ±0  0 ❌ ±0 

Results for commit da82d35. ± Comparison against base commit be4572d.

@mcollovati mcollovati added the Contribution PRs coming from the community or external to the team label Dec 22, 2022
@mstahv
Copy link
Member Author

mstahv commented Dec 23, 2022

Closing as this approach seems a better start: #15540

@mstahv mstahv closed this Dec 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Contribution PRs coming from the community or external to the team +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mstahv @mcollovati @vaadin-bot