Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Activities table #8

Merged
merged 2 commits into from
Jun 22, 2024
Merged

Add Activities table #8

merged 2 commits into from
Jun 22, 2024

Conversation

sthuray
Copy link
Contributor

@sthuray sthuray commented Jun 15, 2024 •
edited
Loading

Notion ticket link

Activities Table

Implementation description

  • created activity model
  • created migration file

Steps to test

  1. Check database for activities table

What should reviewers focus on?

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

jerry-cheng5
jerry-cheng5 approved these changes Jun 15, 2024
View reviewed changes
Copy link
Contributor

@jerry-cheng5 jerry-cheng5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@sthuray sthuray force-pushed the S24/sayi/add-activities-table branch from 61f9a73 to 16101c7 Compare June 15, 2024 18:32
aanxniee
aanxniee approved these changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@aanxniee aanxniee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

MinIcecream
MinIcecream approved these changes Jun 22, 2024
View reviewed changes
Copy link
Contributor

@MinIcecream MinIcecream left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sthuray sthuray merged commit fb3e845 into main Jun 22, 2024
1 check passed
@sthuray sthuray deleted the S24/sayi/add-activities-table branch June 22, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerry-cheng5 jerry-cheng5 jerry-cheng5 approved these changes

@aanxniee aanxniee aanxniee approved these changes

@MinIcecream MinIcecream MinIcecream approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sthuray @jerry-cheng5 @aanxniee @MinIcecream