Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S24/daniel/changing login and landing page #20

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

MinIcecream
Copy link
Contributor

Notion ticket link

Login Page and Landing Page Skeleton

Implementation description

  • Created a placeholder landing page, made HOME_PAGE route to it instead of the previous default page
  • Removed sign up and google login buttons from login page

Steps to test

  1. Go to the login page to view the updated login page
  2. Login to view the new landing page

Checklist

  • [ x] My PR name is descriptive and in imperative tense
  • [ x] My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • [x ] I have run the appropriate linter(s)
  • [ x] I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
image image

@@ -6,7 +6,7 @@ import Login from "./components/auth/Login";
import Signup from "./components/auth/Signup";
import PrivateRoute from "./components/auth/PrivateRoute";
import CreatePage from "./components/pages/CreatePage";
import Default from "./components/pages/Default";
import LandingPage from "./components/pages/LandingPage";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's name this to PetListPage

Copy link
Contributor

@aanxniee aanxniee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, feel free to merge after the renaming!

@MinIcecream MinIcecream merged commit f2231b1 into main Jul 3, 2024
1 check passed
@MinIcecream MinIcecream deleted the S24/daniel/changing-login-and-landing-page branch July 3, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants