Feature: New setting to ignore running on untitled files #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It should be false by default. The rest looks fine. |
|
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of our extensions, Quokka.js (2.7M+ installs) creates a new untitled file for users to experiment with their code. In the last few weeks, we've had a number of our users think it's not working properly (especially for TypeScript files) because Error Lens is reporting inline errors.
I believe that running on untitled files (not yet saved to disk) is probably not what people want (by default) and have created a pull request with a new feature to enable/disable running on untitled files.
Happy to change the default or make any other changes so we can make our extension work more nicely with yours. Feel free to change my pull request / changes yourself if your prefer.