Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update broker to rabbitmq:3.11.28 #3670

Merged
merged 3 commits into from
Jun 12, 2024
Merged

chore: update broker to rabbitmq:3.11.28 #3670

merged 3 commits into from
Jun 12, 2024

Conversation

tobybellwood
Copy link
Member

@tobybellwood tobybellwood commented Mar 7, 2024

You need to upgrade to 3.11 to activate the feature flags required in 3.12, so will split this update over a couple of releases.

There is a manual step to be performed once on this version of RabbitMQ to enable all the feature flags

rabbitmqctl list_feature_flags
rabbitmqctl enable_feature_flag all

https://www.rabbitmq.com/docs/feature-flags#key-cli-tool-commands

@tobybellwood tobybellwood added this to the 2.19.0 milestone Mar 13, 2024
@tobybellwood tobybellwood modified the milestones: 2.19.0, 2.20.0 Apr 30, 2024
@shreddedbacon
Copy link
Member

This will also need accompanying notes in the release pages in the docs to indicate the requirement (even though we do recommend people update to every minor version, you never know 🙈 )

@tobybellwood tobybellwood marked this pull request as ready for review May 24, 2024 00:34
@shreddedbacon
Copy link
Member

Is there going to be a manual step that users will need to perform on the release that this would appear in?

@tobybellwood
Copy link
Member Author

Is there going to be a manual step that users will need to perform on the release that this would appear in?

Yes - after this release has been deployed,, all the feature flags will need to be enabled via the command line before progressing to the 3.12 release out next.

@shreddedbacon
Copy link
Member

Yes - after this release has been deployed,, all the feature flags will need to be enabled via the command line before progressing to the 3.12 release out next.

Hmm, it would be nice if we can figure out a way to avoid it being a manual step

@tobybellwood
Copy link
Member Author

Example output on a vanilla 3.11 install enables all feature flags not enabled by default

check broker is running
enabling any disabled feature flags
 - enabling direct_exchange_routing_v2
 - enabling feature_flags_v2
 - enabling listener_records_in_ets
 - enabling stream_sac_coordinator_unblock_group
 - enabling stream_single_active_consumer
 - enabling tracking_records_in_ets
all feature flags enabled

Copy link
Member

@shreddedbacon shreddedbacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the use within the charts repository uselagoon/lagoon-charts#666. This looks good

@tobybellwood tobybellwood merged commit 2331ec6 into main Jun 12, 2024
1 check passed
@tobybellwood tobybellwood deleted the docker-updates branch June 12, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants