fix: move NATS message definitions into separate package #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes a bug where ssh-portal binaries were unnecessarily exposing ssh-portal-api related metrics (these metrics are always zero in ssh-portal). Previously ssh-portal's sshserver package was importing sshportalapi (and thus getting the unnecessary metrics) just for the bus message struct definitions. By moving the message struct definitions out into their own package, both sshserver and sshportalapi can import the message definitions as required without any side effects (such as metrics registrations).
smlx
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes a bug where ssh-portal binaries were unnecessarily
exposing ssh-portal-api related metrics (these metrics are always zero
in ssh-portal).
Previously ssh-portal's sshserver package was importing sshportalapi
(and thus getting the unnecessary metrics) just for the bus message
struct definitions.
By moving the message struct definitions out into their own package,
both sshserver and sshportalapi can import the message definitions as
required without any side effects (such as metrics registrations).