Upgrade nats subchart to v1.0 #602
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smlx
force-pushed
the
nats-1.0
branch
4 times, most recently
from
79b3cda
to
579db92
Compare
smlx
force-pushed
the
nats-1.0
branch
4 times, most recently
from
8c9e280
to
9fa707b
Compare
smlx
force-pushed
the
nats-1.0
branch
3 times, most recently
from
3796af2
to
276d42c
Compare
smlx
force-pushed
the
nats-1.0
branch
6 times, most recently
from
4d0ee57
to
2d86588
Compare
tobybellwood
force-pushed
the
nats-1.0
branch
from
2d86588
to
67e9493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the NATS subchart dependency to 1.0.
This is a breaking change. The NATS chart has completely restructured its configuration between v0.x and v1.x.
So by necessity the NATS subchart configuration of
lagoon-coreandlagoon-remotealso had to be restructured.In general, the major upstream change affecting the Lagoon charts is that
nats.*values have mostly been moved tonats.config.*.In particular, the following values required by the Lagoon charts have changed:
Lagoon Core:
nats.cluster.namenats.config.cluster.namenatsConfig.tls.secretData."server.crt"natsConfig.tls.secretData."tls.crt"natsConfig.tls.secretData."server.key"natsConfig.tls.secretData."tls.key"Lagoon Remote:
nats.cluster.namenats.config.cluster.namenatsConfig.tls.secretData."client.crt"natsConfig.tls.secretData."tls.crt"natsConfig.tls.secretData."client.key"natsConfig.tls.secretData."tls.key"In addition, any other NATS subchart configuration options that may have been added (anything under
nats.*in thevalues.yamloflagoon-coreandlagoon-remote) will most likely require updating.There are upstream notes on the changes in the NATS chart here.
The other change in this PR is that the client certificates presented by Lagoon Remote are now validated by NATS in Lagoon Core (they were not previously validated correctly).
This should not be a breaking change if the previous instructions for generating certificates were followed correctly.
Also note that due to the breaking change this is a major version bump for
lagoon-corefromv1.xtov2.x.This is not a major version bump for
lagoon-remotebecause that is still atv0.x.