Queue a reconcile request after marking the resource as ready #262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
force-pushed
the
queue-after-ready
branch
4 times, most recently
from
a906dc9
to
2f18c26
Compare
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
ulucinar
force-pushed
the
queue-after-ready
branch
from
2f18c26
to
8e859d6
Compare
sergenyalcin
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
I tested this PR against to the provider-gcp and I validated a reconciliation is requested after making the resource as ready.
Thanks @ulucinar LGTM.
|
Thank you @sergenyalcin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
With this PR, right after marking a managed resource as ready (adding the
Ready=Truestatus condition), we queue a reconcile request because the status updates will no longer trigger a reconciliation and there may be a need for a subsequent reconcile for late-initialization. Currently, we need to wait for the poll interval after marking a resource as ready before it's late-initialized as we prioritize marking a resource as ready over late-initializing it unlike the community providers (this is at least the case for the community AWS provider).We are also planning to change this behavior and simplify the logic implemented here in a future PR.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Please see the comment below.