Hide AP password in the config page and on console #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar functionality is also available in upstream WiFiManager . |
universam1
requested changes
Apr 4, 2021
This reverts commit a5dbcfa.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These commits remove display of WiFi passwords from the serial console and config pages.
The wifimanagerKT config page was missing the type="password" setting on the wifi password input field. This hides display of the wifi password. Also, if you configure the config access point to use a password, this password was shown on the console. This has been commented out but left in case someone needs it for debugging.
Note: I have not tested either of these on a board yet. Will update once I've confirmed they are working ok.