Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nightly workflow runner links and run logic #460

Merged
merged 5 commits into from
Aug 9, 2023

Conversation

PoisonPhang
Copy link
Contributor

@PoisonPhang PoisonPhang commented Aug 9, 2023

This closes #443 by using the provided github environment vars to create a link to the run.
Debug issue #458 demonstrates this fix working.

This also closes #452 by using single quotes instead of double quotes.

@PoisonPhang PoisonPhang linked an issue Aug 9, 2023 that may be closed by this pull request
@PoisonPhang PoisonPhang marked this pull request as ready for review August 9, 2023 16:35
@PoisonPhang PoisonPhang merged commit 9829211 into main Aug 9, 2023
118 checks passed
@PoisonPhang PoisonPhang deleted the 443-nightly-workflow-fails-to-link-failed-runs branch August 9, 2023 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly workflow is incorrectly formatted Nightly workflow fails to link failed runs
2 participants