Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move IBC and cometbls move light client #2662

Merged
merged 60 commits into from
Aug 29, 2024
Merged

Move IBC and cometbls move light client #2662

merged 60 commits into from
Aug 29, 2024

Conversation

aeryz
Copy link
Contributor

@aeryz aeryz commented Aug 5, 2024 •
edited
Loading

Closes #2660

Implemented modules:

  • IBC protocol
    • Client creation
    • Connection handshake
    • Channel handshake
    • Packet send/recv/ack
  • Light clients
    • Cometbls LC on Move
    • Movement LC on Union
  • Libraries
    • Cometbls Groth16 verifier
    • Optimized ICS23
    • Protobuf impls for necessary types

@netlify Netlify
Copy link

netlify bot commented Aug 5, 2024 •
edited
Loading

✅ Deploy Preview for unionlabs ready!

Name Link
🔨 Latest commit 4a795ee
🔍 Latest deploy log https://app.netlify.com/sites/unionlabs/deploys/66d054ac68a4e50008027013
😎 Deploy Preview https://deploy-preview-2662--unionlabs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 40 (🔴 down 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 93 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

aeryz and others added 4 commits August 22, 2024 20:48
@aeryz
chore(move): cometbls verifier test passes
290ff17 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore: import aptos
c78289d 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
feat(move): started ibc implementation with move
fc2753b 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(cometbls-move): split pairing
fbe9265 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz marked this pull request as ready for review August 29, 2024 09:51
Caglankaan and others added 23 commits August 29, 2024 12:57
@Caglankaan @aeryz
chore(move-ibc): create_client with event emitting in it
6cc34ca 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@Caglankaan @aeryz
chore(move-ibc): fixed global storage usage, removed registerclient
32ad7f9 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@Caglankaan @aeryz
chore(move-ibc): lightclient api design
7620993 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(cometbls-move): fix apis
5f4012b 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(cometbls-move): integrate zk verifier
2c68938 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(cometbls-move): create_client tests
635b467 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
feat: added connection handshake with test cases
4b43e1e 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(cometbls-move): state constructors
d0d1065 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
chore: fixed create client test case
13e0fe9 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
feat(move-ics23): implement optimized existence proof verification
a810c3a 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move): create proper movement executable
eb3fbd2 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move-ics23): implement varint and test
7d5cde7 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
feat: channel handshake helpers + openinit
8847868 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(move-proto): decode varint and field
bf3dffd 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
feat(move-ibc): added channel open init
236c4c7 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(move-ibc): fix storage issue
0565230 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
feat(move-ibc): channel handshake finalized with test cases
80176fd 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@Caglankaan @aeryz
chore(move-ibc): refactored event usage, fixed warnings
38a8181 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(move-proto): more proto decode impls
2423554 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@Caglankaan @aeryz
chore(ibc-move): recvpacket - sendpacket with pinpong app
bb38fc2 
Signed-off-by: kaancaglan <caglankaan@gmail.com>
@aeryz
chore(move-ibc): complete connectionend proto encode/decode
74af8ac 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move-ibc): wip integrate connection end
deac580 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move-ibc): use connectionend
2179c79 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(ics08-movement): transaction proof
f1b3a73 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): start implementing movement types
9a06391 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): move types to unionlabs
a9f2da8 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): impl protos for aptos types
ece82b5 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): complete aptos proto impl
94468eb 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): derive model in missing types
c3c8244 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(ics08-movement): mock impl IbcClient
6be6112 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(unionlabs): add tx_proof to movement header
b9897d1 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat: intoduce aptos-verifier
51de7d5 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(ics08-movement): header verification
91251d8 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(aptos-verifier): existence proof verification
78ee9ed 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(ics08-movement): membership verification
2de0e22 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(cometbls-move): membership verification
d20a3cc 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move): proper signer handling in callbacks
0bd9d5b 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move-ibc): capability authentications
210adc3 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
fix(move-ibc): packet commitments
d2bf058 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore(move-ibc): name improvements and missing signers
bdbb1cb 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
chore: fmt
e458319 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz
feat(devnet): add ics08-movement to union devnet
fb603ab 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
benluelo
benluelo reviewed Aug 29, 2024
View reviewed changes
Copy link
Contributor

@benluelo benluelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, great work! left a few comments to make issues out of. one question, what is the standard for file names in move? we use both PascalCase and snake_case currently

lib/unionlabs/src/aptos/hash_value.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/aptos/public_key.rs Outdated Show resolved Hide resolved
lib/unionlabs/src/aptos/signature.rs Outdated Show resolved Hide resolved
light-clients/movement/ics08-movement/Cargo.toml Show resolved Hide resolved
move/move-ibc/sources/IBCComittment.move Outdated Show resolved Hide resolved
@aeryz
chore(move-ibc): use snake case for naming
921abd0 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
This was referenced Aug 29, 2024
Open
Open
@aeryz aeryz requested a review from benluelo August 29, 2024 10:13
@aeryz
chore: fix hubble
4a795ee 
Signed-off-by: aeryz <abdullaheryz@protonmail.com>
@aeryz aeryz merged commit 5fb0391 into main Aug 29, 2024
205 checks passed
@aeryz aeryz deleted the movement branch August 29, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benluelo benluelo benluelo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement cometbls move light client
3 participants
@aeryz @benluelo @Caglankaan