Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AB#208629]-add new column in payments table #4278

Merged
merged 8 commits into from
Oct 8, 2024
Merged

[AB#208629]-add new column in payments table #4278

merged 8 commits into from
Oct 8, 2024

Conversation

mmaciekk
Copy link
Contributor

@mmaciekk mmaciekk commented Oct 2, 2024

@mmaciekk mmaciekk added the frontend Changes in FE code label Oct 2, 2024
@mmaciekk mmaciekk self-assigned this Oct 2, 2024
@@ -99,6 +93,17 @@ export function PaymentsTableRow({
);
};

const renderPaymentStatusBox = (): React.ReactElement => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we display all possible statuses?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes WE should.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed:
image

Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.26%. Comparing base (3ab9666) to head (aae4fc9).
Report is 9 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4278      +/-   ##
===========================================
- Coverage    77.53%   77.26%   -0.28%     
===========================================
  Files          968      968              
  Lines        45796    45796              
===========================================
- Hits         35510    35386     -124     
- Misses       10286    10410     +124     
Flag Coverage Δ
e2e 52.13% <ø> (-2.49%) ⬇️
unittests 76.18% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@domdinicola
Copy link
Collaborator

@mmaciekk pls resolve conflicts

@mmaciekk mmaciekk merged commit b024d0d into develop Oct 8, 2024
13 checks passed
@mmaciekk mmaciekk deleted the pp-filter branch October 8, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Changes in FE code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants