Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PM: Supporting documents #4260

Merged
merged 33 commits into from
Oct 3, 2024

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Sep 24, 2024

AB#190339: Payment Module - Enable user to upload supporting documents

updates:

  1. paymentPlan added supportingDocuments:
image
  1. new endpoints api/rest/swagger/
image

url example:
http://localhost:3000/api/rest/afghanistan/programs/UHJvZ3JhbU5vZGU6MDAwMDAwMDAtMDAwMC0wMDAwLTAwMDAtZmFjZWIwMGMwMDAw/payment-plans/UGF5bWVudFBsYW5Ob2RlOjAwMDAwMDAwLWZlZWQtYmVlZi0wMDAwLTAwMDAwYmFkZjAwZA%3D%3D/supporting-documents/WQtYmVlZi0wMDAwLTAwM/

@pavlo-mk pavlo-mk added backend Changes in BE code frontend Changes in FE code work in progress Change doesn't need to be reviewed labels Sep 24, 2024
@pavlo-mk pavlo-mk self-assigned this Sep 24, 2024
@mmaciekk mmaciekk self-assigned this Sep 25, 2024
@pavlo-mk pavlo-mk changed the title WIP // PM: Supporting documents PM: Supporting documents Sep 26, 2024
@pavlo-mk pavlo-mk requested review from MarekBiczysko, johniak and mmaciekk and removed request for MarekBiczysko and johniak September 26, 2024 12:35
src/hct_mis_api/apps/payment/api/views.py Outdated Show resolved Hide resolved
src/hct_mis_api/apps/payment/api/views.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 96.93878% with 3 lines in your changes missing coverage. Please review.

Project coverage is 77.91%. Comparing base (bbf6217) to head (3ad14ed).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/payment/api/views.py 93.10% 2 Missing ⚠️
src/hct_mis_api/apps/payment/models.py 91.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4260      +/-   ##
===========================================
- Coverage    78.15%   77.91%   -0.24%     
===========================================
  Files          986      988       +2     
  Lines        47719    47813      +94     
===========================================
- Hits         37296    37255      -41     
- Misses       10423    10558     +135     
Flag Coverage Δ
e2e 52.84% <68.36%> (-2.09%) ⬇️
unittests 76.87% <96.93%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk merged commit 50a2d06 into develop Oct 3, 2024
13 checks passed
@pavlo-mk pavlo-mk deleted the new_190339_Payment_plan_supporting_documents branch October 3, 2024 20:25
domdinicola added a commit that referenced this pull request Oct 8, 2024
* 2201639_Individuals_Add_a_new_section_to_Display_Delivery_mechanism_details_for_an_individual

* mypy

* mypy

* move all the changes into new structure

* linter

* adjust options

* try with assert

* adjust factory

* fix e2e

* PaymentPlan details show Exchange Rate + Summary PDF (#4240)

* update pdf template

* black

* add exchange rate in pp details

* upd fe schema

---------

Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>

* 208491: RDI - Rename label to 'Total number of registered Individuals' (#4261)

* upd label

* upd fe test snap

* fix e2e

* snaps

---------

Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>

* Deduplication engine integration demo fixes (#4253)

* e2e edjustment + increase retry

* resolve migration conflict

* add compose file for running selenium locally, adjust readme

* try

* trial

* try

* ?

* ok

* hotfix_add_financial_payment_provider_inline_validation (#4193)

* remove lazy query

* fixed health check

* fix e2e

* added db host

* validate unique ind for role in hh

* linter

* noqa

* Changes to Project structure (#4269)

* structure

* fix docker compose

* Changes to project structure and Docker image building
- Project installs as packaget on dist image
- Rebuild dockerfile structure
- removed unused file
- addjusted entrypoint and manage.py

* fix code style

* selenium test fixes

* changed settings

---------

Co-authored-by: Domenico DiNicola <dom.dinicola@gmail.com>

* mypy

* fixes after structure change

* fail fast selenium

* fix e2e yesy

* remove comented headless

* e2e fixes

* fixed file path

* fixed report path

* run all tests

* fixes to reports and coverage

* 2212815_Needs_adjudication_Delays_in_creating_duplicate_tickets_after… (#4276)

* Program cycle requred for TP, adjust create TP from list in admin

* linter

* fix tests creating TPs without cycles

* skip forms

* fixed  test

* bring back nighlt runs for tests marked before

* 2216761_Adapt_Dedup_integration (#4280)

* 2216761_Adapt_Dedup_integration

* add migration

---------

Co-authored-by: marekbiczysko <marek.biczysko@tivix.com>

* remove usd from label (#4281)

Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>

* text

* skip trivy failure

* Project structure 3 (#4287)

* chenged tests dir

* fixed all linter problems

* fix  precomit

* fix compose

* fixed  tests root dir

* Update compose.yml

uncoment  volume

* adjust test to testcase

* remove edopomoga

* include src in path

* linter

* PM: Supporting documents (#4260)

* add new model

* add new urls

* add test & migrations

* imports

* tests & fixes

* add modal for supporting documents

* add delete, fix doc layout

* add supporting docs to follow up pages

* add title validation

* textfield size small

* regenerate schema

* add error for > 10 files, accept other filetypes

* add message when deleting doc

* display both title and file name

* upd e2e test_smoke_details_payment_plan

* review

* fix urls in tests

* migrations

* fix download resp

* fix

* add get_id

* supporting docs fixes

* mypy

* fixes

---------

Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>

* fix test admin

* fix coveragerc

* add ignore to codecov files

* move ignored paths to codecov.yml

* fixed retrieving version

* add vision app (#4274)

* contrib refactoring

* contrib refactoring

---------

Co-authored-by: Pavlo Mokiichuk <pv.pasha.pv@gmail.com>

* change text of xlsx individual update for invalid phone no

* include file

* linter

* Provide superusers and testers via env/arg to `initdemo` (#4295)

* add index on document number

* 216761 adapt dedup integration (#4298)

* [Back merge] prod>STG (#4294) (#4296)

* [hotfix] 216567 deduplication key error when deduplicating records (#4271)

* 2216567_Deduplication_Key_Error_when_deduplicating_records

* black

* remove distinct

* fix dedup logic, add ut

* lint

---------



* skip trivy failure

* fix document status when copy population (#4291)

---------

Co-authored-by: Pavlo Mokiichuk <pv.pasha.pv@gmail.com>
Co-authored-by: Marek Biczysko <34810846+MarekBiczysko@users.noreply.github.com>
Co-authored-by: marekbiczysko <marek.biczysko@tivix.com>
Co-authored-by: Bartosz Woźniak <17177420+wozniakpl@users.noreply.github.com>

---------

Co-authored-by: marekbiczysko <marek.biczysko@tivix.com>
Co-authored-by: Marek Biczysko <34810846+MarekBiczysko@users.noreply.github.com>
Co-authored-by: Paulina Kujawa <p.kujawa2f@gmail.com>
Co-authored-by: Pavlo Mokiichuk <pv.pasha.pv@gmail.com>
Co-authored-by: Maciej Szewczyk <maciej.szewczyk@tivix.com>
Co-authored-by: Maciej Szewczyk <34482854+mmaciekk@users.noreply.github.com>
Co-authored-by: Paulina Kujawa <42150286+pkujawa@users.noreply.github.com>
Co-authored-by: Jan Romaniak <jan.romaniak@kellton.com>
Co-authored-by: Jan Romaniak <jan.romaniak@tivix.com>
Co-authored-by: Bartosz Woźniak <17177420+wozniakpl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Changes in BE code frontend Changes in FE code work in progress Change doesn't need to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants