Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ungoogled-chromium 127.0.6533.72-1 #367

Merged
merged 1 commit into from
Jul 27, 2024

Conversation

teeminus
Copy link
Contributor

Builds and runs fine:

image

Noteable changes:

  • README.md
    • Added update procedure for new dependencies
  • build.py
    • Fixed logic bug I introduced when switching to the clone script. Previously, we pruned the source folder after extracting the downloads. This can make the extraction of downloads fail if the source file is already/still present as clone script and tarball extraction populated the source folder at different steps in the build chain. Therefore I updated the program flow to first prepare the source folder by either using the clone script or extracting the chromium tarball. Then the source folder is pruned and then the windows specific downloads are extracted.
    • Bump of rust toolchain
    • The rust compiliation now requires the bindgen (.exe) binary which I did not find as binary download. Luckily, they ship a build script to compile the binary from source on the build machine
  • downloads.ini
    • Added DirectX-Headers
    • Added windows-rs rust crate
  • patches/series / ungoogled-chromium/windows/windows-disable-nodebug_assertion.patch
    • Patch became obsolete
  • patches/ungoogled-chromium/windows/windows-fix-building-with-rust.patch
    • I had to patch two GN files to update the location of two required rust libs that are pruned and have to be downloaded manually now
    • I also had to patch the build script for the bindgen.exe binary to work with our toolchain

@teeminus teeminus requested a review from a team July 27, 2024 17:22
@teeminus teeminus merged commit 1a37396 into ungoogled-software:master Jul 27, 2024
@teeminus teeminus deleted the update branch July 27, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants