Skip to content

Commit

Permalink
Merge pull request #295 from teeminus/fix_python_requirements
Browse files Browse the repository at this point in the history
  • Loading branch information
teeminus authored Dec 1, 2023
2 parents dd6b90b + 5c1fe50 commit 78b3059
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 6 deletions.
10 changes: 6 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,17 @@ NOTE: The default configuration will build 64-bit binaries for maximum security

1. Setup the following:
* 7-Zip
* Python 3.6 - 3.9 or 3.10.2+ (for build and packaging scripts used below); Python 3.11 and above is not supported.
* Python 3.8 - 3.10 (for build and packaging scripts used below); Python 3.11 and above is not supported.
* If you don't plan on using the Microsoft Store version of Python:
* Check "Add python.exe to PATH" before install.
* At the end of the Python installer, click the button to lift the `MAX_PATH` length restriction.
* Check "Add python.exe to PATH" before install.
* At the end of the Python installer, click the button to lift the `MAX_PATH` length restriction.
* Check that your `PATH` does not contain the `python3` wrapper shipped by Windows, as it will only prompt you to install Python from the Microsoft Store and exit. See [this question on stackoverflow.com](https://stackoverflow.com/questions/57485491/python-python3-executes-in-command-prompt-but-does-not-run-correctly)
* Ensure that your Python directory either has a copy of Python named "python3.exe" or a symlink linking to the Python executable.
* Make sure to lift the `MAX_PATH` length restriction, either by clicking the button at the end of the Python installer or by [following these instructions](https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#:~:text=Enable,Later).
* Make sure to lift the `MAX_PATH` length restriction, either by clicking the button at the end of the Python installer or by [following these instructions](https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-limitation?tabs=registry#:~:text=Enable,Later).
* Git (to fetch all required ungoogled-chromium scripts)
* During setup, make sure "Git from the command line and also from 3rd-party software" is selected. This is usually the recommended option.
* The following additional python modules needs to be installed using `pip install`:
* httplib2

### Building

Expand Down
4 changes: 2 additions & 2 deletions build.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
import sys
import time

if sys.version_info.major < 3 or sys.version_info.minor < 6:
raise RuntimeError('Python 3.6+ is required for this script. You have: {}.{}'.format(
if sys.version_info.major != 3 or sys.version_info.minor < 8 or sys.version_info.minor > 10:
raise RuntimeError('Python 3.8 to 3.10 is required for this script. You have: {}.{}'.format(
sys.version_info.major, sys.version_info.minor))

import argparse
Expand Down

0 comments on commit 78b3059

Please sign in to comment.