Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: externals and postcssOptions type in umd #655

Merged
merged 1 commit into from
May 31, 2023

Conversation

cloudyan
Copy link
Contributor

umd 配置中,externals 与 postcssOptions 应该是可选配置吧

umd 配置中,externals 与 postcssOptions 应该是可选配置吧
@codecov
Copy link

codecov bot commented May 31, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (a800fe4) 93.66% compared to head (c1a197a) 93.66%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #655   +/-   ##
=======================================
  Coverage   93.66%   93.66%           
=======================================
  Files          55       55           
  Lines        1515     1515           
  Branches      333      333           
=======================================
  Hits         1419     1419           
  Misses         96       96           
Impacted Files Coverage Δ
src/types.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@PeachScript PeachScript changed the title umd 配置中,externals 与 postcssOptions 是可选项? fix: externals and postcssOptions type in umd May 31, 2023
Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@PeachScript PeachScript merged commit e50f7af into umijs:master May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants