Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 'prebundle' is preset in correct env template #631

Merged
merged 3 commits into from
Apr 19, 2023

Conversation

BoyYangzai
Copy link
Member

@BoyYangzai BoyYangzai commented Apr 18, 2023

image
不知是否刻意设置 如果是 建议更改模板 加上 deps:{ }

@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (33bfffc) 94.91% compared to head (30f87fe) 94.91%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #631   +/-   ##
=======================================
  Coverage   94.91%   94.91%           
=======================================
  Files          55       55           
  Lines        1494     1494           
  Branches      355      355           
=======================================
  Hits         1418     1418           
  Misses         75       75           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BoyYangzai
Copy link
Member Author

@PeachScript peach老师cc

@PeachScript
Copy link
Member

感觉是模板有问题而不是类型有问题,空的 prebundle 确实没有实际意义,你看看是不是更新模板更合适:

  1. prebundle 默认加上 deps: []
  2. 仅选择 Node.jsBoth 才放置 prebundle

Copy link
Member

@PeachScript PeachScript left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@BoyYangzai BoyYangzai changed the title fix: error ts type in create-father template fix: 'prebundle' is preset in correct env template Apr 19, 2023
@PeachScript PeachScript merged commit bc90e3a into umijs:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants