Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parse tsconfig.json error #157

Merged
merged 3 commits into from
Nov 28, 2019
Merged

fix: parse tsconfig.json error #157

merged 3 commits into from
Nov 28, 2019

Conversation

zhanba
Copy link
Collaborator

@zhanba zhanba commented Nov 27, 2019

  • tsconfig.json 不是严格的json, tsc --init生成的默认 tsconfig.josn 就带有很多注释。
    这里将JSON.parse 换成ts自带的api,保证兼容。
  • 另外修复一个小的测试bug。

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@e54641b). Click here to learn what that means.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #157   +/-   ##
=========================================
  Coverage          ?   74.29%           
=========================================
  Files             ?       16           
  Lines             ?      459           
  Branches          ?      160           
=========================================
  Hits              ?      341           
  Misses            ?      117           
  Partials          ?        1
Impacted Files Coverage Δ
packages/father-build/src/babel.ts 81.08% <91.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54641b...7e1331e. Read the comment docs.

@sorrycc sorrycc changed the title fix: fix parse tsconfig.josn error fix: parse tsconfig.josn error Nov 28, 2019
@sorrycc sorrycc merged commit a365375 into umijs:master Nov 28, 2019
@sorrycc sorrycc changed the title fix: parse tsconfig.josn error fix: parse tsconfig.json error Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants