Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .pre-commit-config.yaml #8812

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Update .pre-commit-config.yaml #8812

merged 2 commits into from
Aug 1, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Jul 31, 2022

Comment EOF fixer

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Improved pre-commit checks for cleaner code contributions.

πŸ“Š Key Changes

  • Commented out the 'end-of-file-fixer' pre-commit hook.
  • Left other pre-commit hooks unchanged (i.e., 'trailing-whitespace', 'check-case-conflict', 'check-yaml').

🎯 Purpose & Impact

  • 🧹 The change aims to simplify the pre-commit configuration.
  • πŸš€ This might reduce the unnecessary blocking of commits due to end-of-file issues, streamlining the development workflow.
  • πŸ” Developers may need to manually ensure end-of-file fixer conventions are followed or they could be enforced through a different method.

@glenn-jocher glenn-jocher merged commit 6717519 into master Aug 1, 2022
@glenn-jocher glenn-jocher deleted the glenn-jocher-patch-1 branch August 1, 2022 00:09
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
* Update .pre-commit-config.yaml

Comment EOF fixer

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant