Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict TRT autoinstall to Linux-only #7549

Merged
merged 1 commit into from
Apr 23, 2022
Merged

Restrict TRT autoinstall to Linux-only #7549

merged 1 commit into from
Apr 23, 2022

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented Apr 23, 2022

May partially resolve concerns in #7537 (comment)

πŸ› οΈ PR Summary

Made with ❀️ by Ultralytics Actions

🌟 Summary

Enhanced export.py to conditionally check nvidia-tensorrt requirements based on the operating system.

πŸ“Š Key Changes

  • Added a conditional check to ensure nvidia-tensorrt requirements are only verified on Linux systems.

🎯 Purpose & Impact

  • πŸ› οΈ Purpose: The adjustment is made to prevent irrelevant requirement checks on non-Linux systems which do not support nvidia-tensorrt. This targets avoiding errors or confusion when exporting models on those platforms.
  • πŸ” Impact: Users on non-Linux systems will experience a smoother export process without facing errors related to missing TensorRT libraries, which are not applicable to their operating system. This makes the export script more robust and user-friendly for a wider audience.

May partially resolve concerns in #7537 (comment)
@glenn-jocher glenn-jocher self-assigned this Apr 23, 2022
@glenn-jocher glenn-jocher merged commit 1f1ec1c into master Apr 23, 2022
@glenn-jocher glenn-jocher deleted the update/trt branch April 23, 2022 16:36
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
ctjanuhowski pushed a commit to ctjanuhowski/yolov5 that referenced this pull request Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant