Add requests to requirements.txt
#5112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Requests added to requirements.txt. That might not be included in all docker base images, adding it to the requirements is safer. 2. Added a minimum version to Pandas. It's a good practice to have versions for all dependencies.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @sandstorm12, thank you for submitting a 🚀 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with origin/master. If your PR is behind origin/master an automatic GitHub actions rebase may be attempted by including the /rebase command in a comment body, or by running the following code, replacing 'feature' with the name of your local branch:
git remote add upstream https://github.com/ultralytics/yolov5.git
git fetch upstream
git checkout feature # <----- replace 'feature' with local branch name
git merge upstream/master
git push -u origin -f- ✅ Verify all Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." -Bruce Lee
|
@sandstorm12 thanks for the PR! This is causing conflicts on Colab install |
|
Requests version 2.23.0 is tested.
|
|
@sandstorm12 PR is merged. Thank you for your contributions to YOLOv5 🚀 and Vision AI ⭐ |
Merged
BjarneKuehl
pushed a commit
to fhkiel-mlaip/yolov5
that referenced
this pull request
Aug 26, 2022
* Requirements updated 1. Requests added to requirements.txt. That might not be included in all docker base images, adding it to the requirements is safer. 2. Added a minimum version to Pandas. It's a good practice to have versions for all dependencies. * Sort alphabetically * Update requirements.txt Co-authored-by: Glenn Jocher <glenn.jocher@ultralytics.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ PR Summary
Made with ❤️ by Ultralytics Actions
🌟 Summary
Enhancement of dependencies in the YOLOv5 project's requirements.
📊 Key Changes
requestslibrary with a minimum version of 2.23.0.pandaslibrary.🎯 Purpose & Impact
requestslikely aims to facilitate web requests capabilities for tasks such as downloading data or interacting with web services.pandasensures compatibility and stability when using data frames for analysis and plotting.