Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Curl update #3004

Merged
merged 2 commits into from
May 1, 2021
Merged

Curl update #3004

merged 2 commits into from
May 1, 2021

Conversation

glenn-jocher
Copy link
Member

@glenn-jocher glenn-jocher commented May 1, 2021 •
edited by UltralyticsAssistant
Loading

🛠️ PR Summary

Made with ❤️ by Ultralytics Actions

🌟 Summary

Enhanced robustness in downloading data and weights using curl with retry and resume options.

📊 Key Changes

  • Added curl download option in get_objects365.py and general.py scripts.
  • Improved torch.hub.download_url_to_file by introducing retry logic and resume on failure using curl in google_utils.py.
  • Modified download function argument list to include curl boolean flag, defaulting to False.

🎯 Purpose & Impact

  • The updates aim to make downloads more reliable, especially for large files or under unstable network conditions.
  • Users are likely to experience fewer download interruptions and failures, with automatic retries and resumption of interrupted downloads.
  • The addition of curl support brings more flexibility and potentially faster downloads for users with suitable environments.

@glenn-jocher glenn-jocher merged commit 37eaffe into master May 1, 2021
@glenn-jocher glenn-jocher deleted the curl branch May 1, 2021 15:29
KMint1819 pushed a commit to KMint1819/yolov5 that referenced this pull request May 12, 2021
@glenn-jocher
Curl update (ultralytics#3004)
9e92330 
* Curl update

* Curl update
danny-schwartz7 pushed a commit to danny-schwartz7/yolov5 that referenced this pull request May 22, 2021
@glenn-jocher @danny-schwartz7
Curl update (ultralytics#3004)
9cabb52 
* Curl update

* Curl update
Lechtr pushed a commit to Lechtr/yolov5 that referenced this pull request Jul 20, 2021
@glenn-jocher @Lechtr
Curl update (ultralytics#3004)
1ec23d0 
* Curl update

* Curl update

(cherry picked from commit 37eaffe)
@glenn-jocher glenn-jocher mentioned this pull request Oct 12, 2021
Merged
@glenn-jocher glenn-jocher mentioned this pull request Nov 7, 2021
Closed
@glenn-jocher glenn-jocher mentioned this pull request Nov 14, 2021
Merged
BjarneKuehl pushed a commit to fhkiel-mlaip/yolov5 that referenced this pull request Aug 26, 2022
@glenn-jocher
Curl update (ultralytics#3004)
28a7122 
* Curl update

* Curl update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glenn-jocher