Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate log messages #257

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Conversation

kamilkrzyskow
Copy link
Contributor

MkDocs 1.5 started using f-strings when creating build time log messages, therefore each string is unique (as the time typically changes slightly).
The old solution stopped working, so now instead I've created a different DuplicateFilter class, which looks at the prefix of the log and not the exact match.
Additionally this PR changes makes more logging changes:

  • adds messages about default language being built
  • scopes the lunr.js log warning only to the built language

@kamilkrzyskow kamilkrzyskow mentioned this pull request Sep 7, 2023
Copy link
Owner

@ultrabug ultrabug left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, almost there

mkdocs_static_i18n/plugin.py Outdated Show resolved Hide resolved
mkdocs_static_i18n/utils.py Outdated Show resolved Hide resolved
@ultrabug
Copy link
Owner

Thank you!

@ultrabug ultrabug merged commit 54b2b94 into ultrabug:main Sep 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants