Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: Support groups inside rule-group #1111

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ukrbublik
Copy link
Owner

@ukrbublik ukrbublik commented Aug 29, 2024

Resolves #1108

Copy link

codesandbox bot commented Aug 29, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

vercel bot commented Aug 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-query-builder-examples ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:07pm
react-awesome-query-builder-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:07pm
react-awesome-query-builder-sandbox-next ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2024 4:07pm

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 731b370:

Sandbox Source
@react-awesome-query-builder/examples Configuration
@react-awesome-query-builder/sandbox Configuration
@react-awesome-query-builder/sandbox-simple Configuration
@react-awesome-query-builder/sandbox-next Configuration

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.06%. Comparing base (617ee98) to head (731b370).

Files with missing lines Patch % Lines
packages/core/modules/utils/defaultUtils.js 70.00% 3 Missing ⚠️
...i/modules/components/containers/GroupContainer.jsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1111      +/-   ##
==========================================
- Coverage   82.08%   82.06%   -0.02%     
==========================================
  Files         212      212              
  Lines       11184    11191       +7     
  Branches     1343     1345       +2     
==========================================
+ Hits         9180     9184       +4     
- Misses       1378     1380       +2     
- Partials      626      627       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to add sub-group under array type so we can have nested AND and OR conditionals
1 participant